feat: add observability config #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wenfeng <sxian.wang@gmail.com>
wenfengwang
requested review from
hwjiangkai,
xdlbdy and
ifplusor
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
==========================================
+ Coverage 62.72% 63.01% +0.29%
==========================================
Files 133 144 +11
Lines 12128 13103 +975
==========================================
+ Hits 7607 8257 +650
- Misses 3977 4263 +286
- Partials 544 583 +39
Continue to review full report at Codecov.
|
xdlbdy
reviewed
Dec 15, 2022
|
the k8s.yaml need to add observability config |
hwjiangkai
reviewed
Dec 15, 2022
Signed-off-by: wenfeng <sxian.wang@gmail.com>
This PR was made for contributors, as for k8s.yml, my idea is we could add it after our observability sub-system is ready |
hwjiangkai
approved these changes
Dec 15, 2022
xdlbdy
approved these changes
Dec 15, 2022
wenfengwang
added a commit
that referenced
this pull request
Mar 23, 2023
* feat: add observability config Signed-off-by: wenfeng <sxian.wang@gmail.com> * fix lint Signed-off-by: wenfeng <sxian.wang@gmail.com> * fix suggestions Signed-off-by: wenfeng <sxian.wang@gmail.com> Signed-off-by: wenfeng <sxian.wang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wenfeng sxian.wang@gmail.com
What problem does this PR solve?
Issue Number: close N/a
Problem Summary
add observability config
What is changed and how does it work?
Check List
Tests