-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: abstract cluster operation #338
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
+ Coverage 62.72% 62.77% +0.04%
==========================================
Files 133 144 +11
Lines 12128 13234 +1106
==========================================
+ Hits 7607 8307 +700
- Misses 3977 4338 +361
- Partials 544 589 +45
Continue to review full report at Codecov.
|
9655eaf
to
931d582
Compare
the trigger worker start lost |
e05be35
to
1bd12c7
Compare
Yes, because |
Signed-off-by: wenfeng <sxian.wang@gmail.com>
Signed-off-by: wenfeng <sxian.wang@gmail.com>
5a1b658
to
3c55d1b
Compare
you are right, but I mean the trigger worker which is the Vanus component that runs the trigger, not the trigger controller. otherwise trigger worker status may be running which is not real because the controller is still not ready. Or maybe I mistake the feat of function |
I got you. I wii add it. |
Signed-off-by: wenfeng <sxian.wang@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: abstract cluster operation Signed-off-by: wenfeng <sxian.wang@gmail.com> * fix ut&lint Signed-off-by: wenfeng <sxian.wang@gmail.com> * update Signed-off-by: wenfeng <sxian.wang@gmail.com> * add waiting into trigger Signed-off-by: wenfeng <sxian.wang@gmail.com> Signed-off-by: wenfeng <sxian.wang@gmail.com>
What problem does this PR solve?
Issue Number: close #226
Problem Summary
abstract cluster operation
What is changed and how does it work?
Check List
Tests