Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issues]: implement function "replace_string" - 8 points #375

Closed
Tracked by #355
JieDing opened this issue Dec 29, 2022 · 3 comments · Fixed by #404
Closed
Tracked by #355

[Good First Issues]: implement function "replace_string" - 8 points #375

JieDing opened this issue Dec 29, 2022 · 3 comments · Fixed by #404
Assignees
Labels
good first issue help-wanted Extra attention is needed

Comments

@JieDing
Copy link
Contributor

JieDing commented Dec 29, 2022

Motivation

Vanus Functions are a series of pre-built functions worked within Vanus transformer. By choosing a function, users can specify the way that events will be changed.

It will be a good start if you decide to contribute to Vanus codes.

Details

This function is used to replace a sub-string of an existed json element with a specific new string.

Description

Function name: replace_string

Function args:

  • path: the json path of the string which needs to be replaced.
  • subValue: the sub-string you'd like to replace.
  • targetValue: the string used to replace the old one.

Function description: Replace a sub-string of an existed json element with a specific new string. The previous value of the json object will be replaced.

Example

For example, if users' original event looks like this:

{
    "specversion" : "1.0",
    "type" : "com.example.someevent",
    "source" : "/mycontext",
    "subject": null,
    "id" : "C234-1234-1234",
    "time" : "2018-04-05T17:31:00Z",
    "comexampleextension1" : "value",
    "comexampleothervalue" : 5,
    "datacontenttype" : "application/json",
    "data" : {
        "appinfoA" : "this is jay ding",
        "appinfoB" : 123,
        "appinfoC" : true
    }
}

After the function "replace_string":

"pipeline":[
    {"command":["replace_string","$.data.appinfoA","jay","Michael"]}
]

The transformed event should look like:

{
    "specversion" : "1.0",
    "type" : "com.example.someevent",
    "source" : "/mycontext",
    "subject": null,
    "id" : "C234-1234-1234",
    "time" : "2018-04-05T17:31:00Z",
    "comexampleextension1" : "value",
    "comexampleothervalue" : 5,
    "datacontenttype" : "application/json",
    "data" : {
        "appinfoA" : "This is Michael ding",
        "appinfoB" : 123,
        "appinfoC" : true
    }
}

How to implement

  1. Fork the vanus repository.
  2. Create a branch function-replace-string
  3. Create replace_string.go under internal/primitive/transform/action/strings, and then implement the function.
  4. Create replace_string_test.go under internal/primitive/transform/action/strings for unit test.
  5. Register your function in internal/primitive/transform/runtime/init.go.
  6. Submit your PR

Contribution points

Each issue counts specific points based on its difficulty. Contributors earn the corresponding points if they solve that issue. Contribution points are used to describe the contributions contributors have made. They can also be used to get rewards when there are community events.

This issue counts 8 points.

How to claim to solve the issue

If you want to implement this function, please leave a comment in this issue like:

I'd like to implement this function, please assign this issue to me.

Vanus community will assign the issue to you on time.

@stavrmaria
Copy link
Contributor

Hi I would like to implement this function, please assign it to me. I have to say I am a beginner I really want to contribute to this project.

@VedaGao
Copy link
Collaborator

VedaGao commented Jan 8, 2023

@stavrmaria Hi, thanks for your comment. I will assign it to you. I hope you're off to a good start.

@JieDing
Copy link
Contributor Author

JieDing commented Jan 9, 2023

Hi I would like to implement this function, please assign it to me. I have to say I am a beginner I really want to contribute to this project.

Hi @stavrmaria , how is it going with this function? You may have some questions during implementation, Join the Slack channel to discuss with other developers. Also there you can know details about how to get contribution rewards.

stavrmaria added a commit to stavrmaria/vanus that referenced this issue Jan 9, 2023
xdlbdy pushed a commit that referenced this issue Jan 10, 2023
* feat: add function replace string
wenfengwang pushed a commit that referenced this issue Mar 23, 2023
* feat: add function replace string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help-wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants