Allow to override background, icon and divider colors #295

RashidianPeyman · 2018-07-29T20:32:03Z

Hello, dear Niklas Baudy (Vacation) first of all, I apologize for my English and thank u for your useful third- party. I use your Emoji third-party in my app but I needed to change background, divider and icon colors programmatically based on my themes. so I fork the Emoji and changed it on demand. now I can use three methods to change background, divider and icon colors in setUpEmojiPopup so we have
this Three :
.setBackgroundColor(Color.parseColor("#BDBDBD"))
.setDividerColor(Color.parseColor("#42A5F5"))
.setIconColor(Color.parseColor("#f0f0f0"))

Although if u don't use them. default values will call and there is no problem

With respect
Peyman Rashidian

…n emoji

vanniktech

Can you revert all of the formatting changes?

vanniktech · 2018-08-09T12:25:48Z

emoji/src/main/java/com/vanniktech/emoji/EmojiPopup.java

@@ -83,24 +87,29 @@
    }
  };

-  EmojiPopup(@NonNull final View rootView, @NonNull final EmojiEditTextInterface editInterface,
-            @Nullable final RecentEmoji recent, @Nullable final VariantEmoji variant) {
+  public EmojiPopup(@NonNull final View rootView, @NonNull final EmojiEditTextInterface editInterface,


Why public?

it added for a test, but I forget to remove it, now its ok

vanniktech · 2018-08-09T12:26:02Z

emoji/src/main/java/com/vanniktech/emoji/EmojiPopup.java

@@ -29,7 +31,8 @@
  static final int MIN_KEYBOARD_HEIGHT = 100;

  final View rootView;
-  final Activity context;
+  private Activity context;
+  private int backgroundColor, iconColor, dividerColor;


Please put each on it's own line

vanniktech · 2018-08-09T12:26:15Z

emoji/src/main/java/com/vanniktech/emoji/EmojiPopup.java

+      return this;
+    }
+
+    @CheckResult public Builder setDividerColor(final int dividerColor) {


Can you add @ColorInt?

yes I will add them

RashidianPeyman · 2018-08-10T15:16:29Z

all revert formatting changes did and revisions have done

vanniktech

There are still some formatting errors.

vanniktech · 2018-08-10T21:38:44Z

emoji/src/main/java/com/vanniktech/emoji/EmojiPopup.java

 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
 import android.view.Gravity;
 import android.view.View;
 import android.view.ViewTreeObserver;
 import android.view.inputmethod.InputMethodManager;
 import android.widget.PopupWindow;
+


revert this one please

vanniktech · 2018-08-10T21:38:57Z

emoji/src/main/java/com/vanniktech/emoji/EmojiPopup.java

@@ -50,7 +56,8 @@
  @Nullable OnEmojiPopupDismissListener onEmojiPopupDismissListener;

  final ViewTreeObserver.OnGlobalLayoutListener onGlobalLayoutListener = new ViewTreeObserver.OnGlobalLayoutListener() {
-    @Override public void onGlobalLayout() {
+    @Override


should be on the same line just as it was previosly

vanniktech · 2018-08-10T21:39:04Z

emoji/src/main/java/com/vanniktech/emoji/EmojiPopup.java


    popupWindow = new PopupWindow(context);

    final OnEmojiLongClickListener longClickListener = new OnEmojiLongClickListener() {
-      @Override public void onEmojiLongClick(@NonNull final EmojiImageView view, @NonNull final Emoji emoji) {
+      @Override


vanniktech · 2018-08-10T21:39:07Z

emoji/src/main/java/com/vanniktech/emoji/EmojiPopup.java

-  EmojiPopup(@NonNull final View rootView, @NonNull final EmojiEditTextInterface editInterface,
-            @Nullable final RecentEmoji recent, @Nullable final VariantEmoji variant) {
+   EmojiPopup(@NonNull final View rootView, @NonNull final EmojiEditTextInterface editInterface,
+                    @Nullable final RecentEmoji recent, @Nullable final VariantEmoji variant, int backgroundColor, int iconColor, int dividerColor) {


vanniktech · 2018-08-10T21:39:12Z

emoji/src/main/java/com/vanniktech/emoji/EmojiPopup.java

        variantPopup.show(view, emoji);
      }
    };

    final OnEmojiClickListener clickListener = new OnEmojiClickListener() {
-      @Override public void onEmojiClick(@NonNull final EmojiImageView imageView, @NonNull final Emoji emoji) {
+      @Override


I tried to fix them in the new commit 😉

vanniktech

Formatting still need some tweaks. Eventually I can also get around it

vanniktech · 2018-08-11T17:43:46Z

emoji/src/main/java/com/vanniktech/emoji/EmojiPopup.java

    this.context = Utils.asActivity(rootView.getContext());
    this.rootView = rootView.getRootView();
-    this.editInterface = editInterface;
+    this.editInterface  = editInterface ;


vanniktech · 2018-08-11T17:43:52Z

emoji/src/main/java/com/vanniktech/emoji/EmojiPopup.java

@@ -149,7 +157,7 @@ public void toggle() {
      if (isKeyboardOpen) {
        // If the keyboard is visible, simply show the emoji popup.
        showAtBottom();
-      } else if (editInterface instanceof View) {
+      } else if (editInterface  instanceof View) {


vanniktech · 2018-08-11T17:44:01Z

emoji/src/main/java/com/vanniktech/emoji/EmojiView.java

+    final View emojiDivider = findViewById(R.id.emoji_divider);
+    if (dividerColor != 0)
+      emojiDivider.setBackgroundColor(dividerColor);
+    else


Braces are missing

is it important to have braces?
You mean that?
if (dividerColor != 0){
emojiDivider.setBackgroundColor(dividerColor);
} else{
emojiDivider.setBackgroundColor(getResources().getColor(R.color.emoji_divider));
}

RashidianPeyman · 2018-08-11T19:04:46Z

thank you Niklas Your hand is open to making the changes

RashidianPeyman · 2018-08-13T15:40:59Z

thank you Niklas 👍👍👍

vanniktech · 2018-08-30T15:41:40Z

There are some findbugs warnings, you want to take a look at it? Otherwise I'll eventually get to it.

vanniktech · 2018-09-09T20:29:03Z

Findbugs is still complaining, I think. Eventually I'll get to it.

vanniktech

This should be good to go now. (I think)

codecov · 2018-09-25T17:31:11Z

Codecov Report

Merging #295 into master will decrease coverage by 0.39%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #295     +/-   ##
=========================================
- Coverage   26.01%   25.62%   -0.4%     
=========================================
  Files          24       25      +1     
  Lines         911      925     +14     
  Branches       99      102      +3     
=========================================
  Hits          237      237             
- Misses        655      669     +14     
  Partials       19       19

Impacted Files	Coverage Δ
...src/main/java/com/vanniktech/emoji/EmojiPopup.java	`0% <0%> (ø)`	⬆️
.../src/main/java/com/vanniktech/emoji/EmojiView.java	`0% <0%> (ø)`	⬆️
...main/java/com/vanniktech/emoji/emoji/CacheKey.java	`0% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3c52dc...8a02df3. Read the comment docs.

RashidianPeyman · 2018-10-01T18:18:08Z

Thank you, Niklas , it's working very well 👍👍

RashidianPeyman and others added 4 commits July 29, 2018 13:08

set background color, icon color and divider color programmatically i…

7b4eddc

…n emoji

some renames

39951b5

clean code

b5d0691

fix update icon color

ad10b11

vanniktech requested changes Aug 9, 2018

View reviewed changes

Apply corrections

09acd83

vanniktech requested changes Aug 10, 2018

View reviewed changes

Some other formatting changes

657a2c1

vanniktech requested changes Aug 11, 2018

View reviewed changes

Apply corrections

ce72e41

vanniktech changed the title ~~change background ,icon and divider colors programmatically~~ Allow to override background ,icon and divider colors Aug 12, 2018

Clean up.

ea525d7

vanniktech changed the title ~~Allow to override background ,icon and divider colors~~ Allow to override background, icon and divider colors Aug 12, 2018

More changes.

832f478

RashidianPeyman closed this Sep 9, 2018

RashidianPeyman reopened this Sep 9, 2018

Fix all of the issues.

8a02df3

vanniktech approved these changes Sep 25, 2018

View reviewed changes

vanniktech merged commit ed266e1 into vanniktech:master Sep 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow to override background, icon and divider colors #295

Allow to override background, icon and divider colors #295

RashidianPeyman commented Jul 29, 2018 •

edited

Loading

vanniktech left a comment

vanniktech Aug 9, 2018

RashidianPeyman Aug 10, 2018 •

edited

Loading

vanniktech Aug 9, 2018

RashidianPeyman Aug 10, 2018

vanniktech Aug 9, 2018

RashidianPeyman Aug 10, 2018

RashidianPeyman commented Aug 10, 2018 •

edited

Loading

vanniktech left a comment

vanniktech Aug 10, 2018

RashidianPeyman Aug 11, 2018

vanniktech Aug 10, 2018

RashidianPeyman Aug 11, 2018

vanniktech Aug 10, 2018

RashidianPeyman Aug 11, 2018

vanniktech Aug 10, 2018

RashidianPeyman Aug 11, 2018

vanniktech Aug 10, 2018

RashidianPeyman Aug 11, 2018 •

edited

Loading

vanniktech left a comment

vanniktech Aug 11, 2018

RashidianPeyman Aug 11, 2018

vanniktech Aug 11, 2018

RashidianPeyman Aug 11, 2018

vanniktech Aug 11, 2018

RashidianPeyman Aug 11, 2018

RashidianPeyman commented Aug 11, 2018 •

edited

Loading

RashidianPeyman commented Aug 13, 2018

vanniktech commented Aug 30, 2018

vanniktech commented Sep 9, 2018

vanniktech left a comment

codecov bot commented Sep 25, 2018

RashidianPeyman commented Oct 1, 2018

Allow to override background, icon and divider colors #295

Allow to override background, icon and divider colors #295

Conversation

RashidianPeyman commented Jul 29, 2018 • edited Loading

vanniktech left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RashidianPeyman Aug 10, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RashidianPeyman commented Aug 10, 2018 • edited Loading

vanniktech left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RashidianPeyman Aug 11, 2018 • edited Loading

Choose a reason for hiding this comment

vanniktech left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RashidianPeyman commented Aug 11, 2018 • edited Loading

RashidianPeyman commented Aug 13, 2018

vanniktech commented Aug 30, 2018

vanniktech commented Sep 9, 2018

vanniktech left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 25, 2018

Codecov Report

RashidianPeyman commented Oct 1, 2018

RashidianPeyman commented Jul 29, 2018 •

edited

Loading

RashidianPeyman Aug 10, 2018 •

edited

Loading

RashidianPeyman commented Aug 10, 2018 •

edited

Loading

RashidianPeyman Aug 11, 2018 •

edited

Loading

RashidianPeyman commented Aug 11, 2018 •

edited

Loading