Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for emoji keyboard UI artifact (while fast scrolling) #223

Merged
merged 2 commits into from
Dec 10, 2017

Conversation

yshubin
Copy link
Contributor

@yshubin yshubin commented Dec 1, 2017

This change fixed UI issue (#221) for fast scrolling (inside emoji keyboard)

Code changes

We just checking if lazy drawable initialization for EmojiImageView already was completed.

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took forever. I'll merge once CI has approved it.

@codecov
Copy link

codecov bot commented Dec 10, 2017

Codecov Report

Merging #223 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #223   +/-   ##
=======================================
  Coverage   28.04%   28.04%           
=======================================
  Files          22       22           
  Lines         820      820           
  Branches       90       90           
=======================================
  Hits          230      230           
  Misses        571      571           
  Partials       19       19
Impacted Files Coverage Δ
...main/java/com/vanniktech/emoji/EmojiImageView.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4815f08...a91d9a8. Read the comment docs.

@vanniktech vanniktech merged commit d4f5344 into vanniktech:master Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants