Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty list memory optimization #201

Merged
merged 1 commit into from Sep 6, 2017
Merged

Empty list memory optimization #201

merged 1 commit into from Sep 6, 2017

Conversation

stefanhaustein
Copy link
Contributor

Don't allocate a list object for empty arrays; use Collections.emptyList() instead.

@codecov
Copy link

codecov bot commented Sep 6, 2017

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   27.93%   27.93%           
=======================================
  Files          22       22           
  Lines         809      809           
  Branches       88       89    +1     
=======================================
  Hits          226      226           
  Misses        565      565           
  Partials       18       18
Impacted Files Coverage Δ
...rc/main/java/com/vanniktech/emoji/emoji/Emoji.java 88.57% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e4d4c...977282c. Read the comment docs.

@vanniktech vanniktech merged commit fb6b106 into vanniktech:master Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants