Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generator for latest changes #166

Merged
merged 1 commit into from
Jul 1, 2017
Merged

Update generator for latest changes #166

merged 1 commit into from
Jul 1, 2017

Conversation

rubengees
Copy link
Collaborator

@rubengees rubengees commented Jul 1, 2017

This updates the generator for the latest changes, which are:

  • NodeJs 8.
  • Adjustments for the latest emoji metadata files.
  • Latest library versions.

I have also included a flag for a larger heap. The default does not seem to be enough with the latest additions.

There are quite some new emojis, but I haven't included them, because they are not ordered correctly yet.

@codecov
Copy link

codecov bot commented Jul 1, 2017

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   30.01%   30.01%           
=======================================
  Files          21       21           
  Lines         753      753           
  Branches       82       82           
=======================================
  Hits          226      226           
  Misses        511      511           
  Partials       16       16

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice. I also like the new Emojis. It's a bit sad that the ios emojis aren't that far yet :D

@vanniktech vanniktech merged commit a56b500 into vanniktech:master Jul 1, 2017
@rubengees rubengees deleted the generator-adjustments branch July 1, 2017 19:31
@rubengees
Copy link
Collaborator Author

Yes, I have seen the ios ones on the unicode website in another document already, but they are not included in the file we are parsing yet 😢. I'll check from time to time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants