Chore/recover linters #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvilelaf
commented
Oct 14, 2022
Comment on lines
+196
to
+197
| - name: Check API Docs updated | ||
| run: tox -e check-api-docs |
There was a problem hiding this comment.
Recovering the check-api-docs
dvilelaf
commented
Oct 14, 2022
Comment on lines
+24
to
+36
| # C0209: consider-using-fstring, # kept as no harm | ||
| # W1514: unspecified-encoding, # kept as no harm | ||
| # R1734: use-list-literal, # kept as no harm | ||
| # R1735: use-dict-literal, # kept as no harm | ||
| # R1732: consider-using-with | ||
| # W0237: arguments-renamed | ||
| # R1733: unnecessary-dict-index-lookup | ||
| # R1710: inconsistent-return-statements | ||
| # R1714: consider-using-in | ||
| # R1729: use-a-generator | ||
| # R0402: consider-using-from-import | ||
| # W0640: cell-var-from-loop | ||
| # C0206: consider-using-dict-items |
There was a problem hiding this comment.
All these were introduced between pylint 2.6.0 to 2.11.1. Now we have introduced Tomte and making that upgrade, we do not want to change our linter settings so these must be skipped.
dvilelaf
commented
Oct 14, 2022
| @@ -277,7 +277,7 @@ def test_extract_wrong_file_type(self): | |||
| """Test for extract method wrong file type.""" | |||
| source = "file.wrong" | |||
| target = "target-folder" | |||
| with self.assertRaises(Exception): | |||
| with self.assertRaises(ValueError): | |||
There was a problem hiding this comment.
Pylint informed that this check was too generic. I could skip the failure, but it seemed very easy to solve. Would you prefer to revert this change and skip the lint error?
There was a problem hiding this comment.
If the test pass no need to revert the change
| @@ -412,7 +412,7 @@ def start(self) -> bool: | |||
| self._thread = Thread( | |||
| target=self._thread_target, name=self.__class__.__name__ # type: ignore # loop was set in set_loop | |||
| ) | |||
| self._thread.setDaemon(True) | |||
| self._thread.daemon = True | |||
There was a problem hiding this comment.
A deprecation: #371 (comment)
DavidMinarsch
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes
n/a
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.