feat(isAlpha): allow usage of options object #2086
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2086 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 105 105
Lines 2324 2328 +4
Branches 586 588 +2
=========================================
+ Hits 2324 2328 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pixelbucket-dev
changed the title
pixelbucket-dev
force-pushed
the
isAlpha-options-refactor
branch
from
217de86
to
8949343
Compare
|
Do you want to work on |
| @@ -1,5 +1,5 @@ | |||
| import assert from 'assert'; | |||
| import validator from '../index'; | |||
There was a problem hiding this comment.
FYI: I don't know what this file is used for, but npm run lint:fix errors here.
| @@ -1,26 +1,38 @@ | |||
| import assertString from './util/assertString'; | |||
| import { alpha } from './alpha'; | |||
|
|
|||
| export default function isAlpha(_str, locale = 'en-US', options = {}) { | |||
| assertString(_str); | |||
There was a problem hiding this comment.
I am referring to the function isAfter. Is it because toDate implicitely runs assertString in already?
I can't remember where but I think we discussed previously that I do two separate PRs. It would be great if we could just merge this one quickly and then I optimise the PR for |
This PR implements steps 1 and 2 of #1874 for
isAlphaand builds upon #2075.This PR extracts tests for
isAlphainto a separate test file ⇾test/validators/isAlpha.test.js(inspired by #1793).Checklist