Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE while preparing next step when step and scenario are finished #143

Merged
merged 4 commits into from
Jun 25, 2018
Merged

Fix NPE while preparing next step when step and scenario are finished #143

merged 4 commits into from
Jun 25, 2018

Conversation

uarlouski
Copy link
Contributor

No description provided.

Copy link
Owner

@valfirst valfirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit tests

@coveralls
Copy link

coveralls commented Jun 22, 2018

Coverage Status

Coverage increased (+0.03%) to 93.424% when pulling 1d636dd on uarlouski:fixNPE into 7d9f52d on valfirst:master.

@uarlouski uarlouski changed the base branch from fork-and-fixes to master June 25, 2018 11:02
@uarlouski uarlouski changed the title Fix NPE when currentStep is equal to null for crawling steps Fix NPE while preparing next step when step and scenario are finished Jun 25, 2018
testCounter.incrementAndGet();
}
// Lifecycle After story steps
if(testState.currentStep == testState.currentScenario) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (

@codeclimate
Copy link

codeclimate bot commented Jun 25, 2018

Code Climate has analyzed commit 1d636dd and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@valfirst valfirst merged commit e893ae8 into valfirst:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants