Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behaviour if examples are used with composite steps #110

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

jsedlace
Copy link

We use plenty of scenarios with Example tables and composite steps and bad enumeration of children for examples caused strange NPE in some jUnit4 classes, which then failed the mvn build.

@jsedlace
Copy link
Author

jsedlace commented Jan 17, 2018

I've just found out that manifestations of the error we met were fix in 8ceeda6, but this PR should solve the root cause.

@coveralls
Copy link

coveralls commented Jan 17, 2018

Coverage Status

Coverage increased (+0.05%) to 92.925% when pulling f8c148a on WanderaOrg:fix-examples-with-composite-steps into 6f00f27 on valfirst:master.

@valfirst valfirst merged commit 7471259 into valfirst:master Jan 17, 2018
@valfirst
Copy link
Owner

@jsedlace, thank you for contribution

@jsedlace
Copy link
Author

@valfirst When you plan to do next release/can you release today or tomorrow?

@valfirst
Copy link
Owner

valfirst commented Jan 17, 2018

@jsedlace, I will release a new version today (in 1-2 hours)

@valfirst
Copy link
Owner

@jsedlace, new release is published (http://repo1.maven.org/maven2/com/github/valfirst/jbehave-junit-runner/2.1.2/):

<dependency>
    <groupId>com.github.valfirst</groupId>
    <artifactId>jbehave-junit-runner</artifactId>
    <version>2.1.2</version>
</dependency>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants