v0 of map-style dataset #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'd like to keep a framework agnostic core in tfrecord/reader.py and tfrecord/writer.py. So the proper way to implement this functionality would be to turn tfrecord_iterator into a class with iter support and make tfrecord_iterator call that class. |
|
That makes sense! I'll refactor things to fit this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added a class that turns the IterableDataset into a Map-style Dataset.
It doesn't currently support manual sharding, or the sequence version of the TFRecordDataset.
It works for the Objectron data that I'm using though.
I'll follow up with a more full-fledged v1 soon, let me know if you can think of anything important for that.