Improve IncrementalPredictor #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… IncrementalPredictor + code cleanup.
JovanVeljanoski
changed the title
maartenbreddels
requested changes
Dec 24, 2019
packages/vaex-ml/vaex/ml/sklearn.py
Outdated
| for j, epoch in enumerate(range(self.num_epochs)): | ||
| progressbar((i2 * self.num_epochs + j) / (N_total * self.num_epochs)) | ||
|
|
||
| # Loop over for each epoch |
There was a problem hiding this comment.
These kinds of comments do not add anything, it says the same as the code below, while after refactoring it is often forgotten, and then lies. Often, when a comment reflects 1 line of code, it should be a more clear line of code without comment, or the comment should explain what is to come in the next N lines.
packages/vaex-ml/vaex/ml/sklearn.py
Outdated
|
|
||
| # Loop over for each epoch | ||
| for epoch in range(self.num_epochs): | ||
| # Loop iterating over the DataFrame |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvements in the
vaex.ml.sklearn.IncrementalPredictor