Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: value counts for high cardinality strings #2147

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Fix: value counts for high cardinality strings #2147

merged 1 commit into from
Aug 17, 2022

Conversation

JovanVeljanoski
Copy link
Member

@JovanVeljanoski JovanVeljanoski commented Aug 3, 2022 •
edited by maartenbreddels
Loading

Closes #2146

  • Make a unit-test
  • unit-test passes

@JovanVeljanoski @maartenbreddels
fix(core): value_counts for strings was sometimes off
aca5277 
This happens more often for high cardinality data, because we initialized
new entries with 1, instead of the count found in the other map when
merging the counters.
@maartenbreddels maartenbreddels force-pushed the fix_value_counts_high_cardinality_string branch from 8d96fa2 to aca5277 Compare August 17, 2022 08:39
@maartenbreddels maartenbreddels merged commit bcc464f into master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maartenbreddels maartenbreddels

Labels
priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG-REPORT] value_counts() on string column returns wrong values
2 participants
@JovanVeljanoski @maartenbreddels