Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ordinal_encode with values which extra entries gave wrong results #2059

Merged
merged 1 commit into from
May 26, 2022
Merged

fix: ordinal_encode with values which extra entries gave wrong results #2059

merged 1 commit into from
May 26, 2022

Conversation

maartenbreddels
Copy link
Member

Fixes #2036

@maartenbreddels maartenbreddels merged commit 9e6b1f2 into master May 26, 2022
@Ben-Epstein
Copy link
Contributor

@maartenbreddels the test here passes with the current vaex version. I think your assertion needs to be
assert not df[df["str_fruit"]=="strawberry"].fruit.ismissing().values.any()

Ben-Epstein added a commit to Ben-Epstein/vaex that referenced this pull request May 31, 2022
@Ben-Epstein
Update category_test.py
9829604 
fix test to reflect vaexio#2059
@Ben-Epstein Ben-Epstein mentioned this pull request May 31, 2022
Merged
maartenbreddels pushed a commit that referenced this pull request Jun 1, 2022
@Ben-Epstein
Update category_test.py (#2069)
f8ed01e 
fix test to reflect #2059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG-REPORT] Vaex leaves out the last value when ordinal encoding
2 participants
@maartenbreddels @Ben-Epstein