-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: "Uncaught (in promise) TypeError: i.register is not a function" #17
Comments
We have the same problem here. The problematic code part from vcf-autocomplete-styles.js is
where register is not found. My guess is, that this What helps is, to add the following import to the above mentioned file: import '@polymer/polymer/lib/elements/dom-module.js'; |
@contradictioned thank you, your solution resolves the error for me as well. We need this fix to be merged and released, as currently the solution is a manual patch. |
I'm facing this issue when I try to run Vaadin App enabling the production mode. Just wanted to mention that this issue has some link with "enabling the production mode", just in case if it is useful for someone who is looking into this issue. |
Could you try 23.0.0 version, that ought to have this issue fixed. At least the demo project started properly when I tried. Sorry for the slow handling of you PR @contradictioned, keep them coming! |
This was already resolved in vaadin-component-factory/vcf-autocomplete#4, but I'm seeing identical behavior now after updating from Vaadin 14 to Vaadin 23.
To briefly recap, the issue is that the plugin works in dev mode, but not in production mode. In production mode, the following error occurs (when minimization is disabled, otherwise the names are slightly more obscure):
When navigating through the stack trace, it becomes clear that this refers to line 14 in the file
theme/lumo/vcf-autocomplete-styles.js
(which istheme.register(theme.id);
). However, the import that was formerly missing in the file is already present, so the error cause is probably similar but not identical.I am using Vaadin 23.0.1 and VCF Autocomplete (Java version) 2.3.2. At the time of this writing, these are the latest versions available. The Vaadin build correctly resolves the client-side dependency to
@vaadin-component-factory/vcf-autocomplete:1.2.8
, which is also the latest available version. Any help would be greatly appreciated.The text was updated successfully, but these errors were encountered: