Some fixes about Hysteria 2 #3147
Conversation
![github-advanced-security[bot]](https://github.com/avatars/in/57789?s=60&v=4){kind=small}
| } | ||
| size := QuicLen(addressLen) + addressLen + QuicLen(paddingLen) + paddingLen |
Check failure
Code scanning / CodeQL
Size computation for allocation may overflow High
There was a problem hiding this comment.
This is not a corrent complaint. Maximum QuicLen is 8, addressLen is validated not to overflow (<= 2048), and paddingLen has a maximum length (511).
| case packetaddr.PacketAddrType_Packet: | ||
| packetAddrDispatcherFactory := udp.NewPacketAddrDispatcherCreator(ctx) | ||
| udpDispatcherConstructor = packetAddrDispatcherFactory.NewPacketAddrDispatcher | ||
| } |
There was a problem hiding this comment.
In order to correctly process packet addr fullcone traffic, the incoming stream should be decoded: https://github.com/v2fly/v2ray-core/blob/master/proxy/trojan/client.go#L90 . I can merge this now without requiring additional changes, but another merge request to support packetaddr is welcomed.
| padding := make([]byte, paddingLen) | ||
| for i := range padding { | ||
| padding[i] = paddingChars[rand.Intn(len(paddingChars))] | ||
| } |
There was a problem hiding this comment.
I don't think the padding have to be filled with something, although it is always a good habit to initialize a buffer. It might be changed in the future, but let's keep it that way for now.
padding mechanism reference: https://github.com/apernet/hysteria/blob/master/core/internal/protocol/padding.go.