Add some development-mode configs for client
#16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-c
approved these changes
Sep 14, 2018
ivan-c
requested changes
Sep 24, 2018
docker-compose.dev.yml
Outdated
| volumes: | ||
| # Be sure you have a local copy of the `tb-mobile-app` repo, | ||
| # and reference it with the `TB_MOBILE_CONTEXT` variable in `.env`. | ||
| - ${TB_MOBILE_CONTEXT}:/usr/src |
There was a problem hiding this comment.
Will this still work if TB_MOBILE_CONTEXT is a link to Github (as is the default)?
If not, can you use a different environment variable?
There was a problem hiding this comment.
No, it'll only work if that points to a local directory.
How about I comment out that line by default, so people can opt-in if they're working with a local copy?
ivan-c
approved these changes
Sep 24, 2018
added 2 commits
September 24, 2018 15:19
The app watches for file changes with the mechanism described at: * facebook/create-react-app#1049
c4lliope
force-pushed
the
client-dev
branch
from
edc5c41
to
50a0f75
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app watches for file changes with the mechanism described at:
Some changes to the mobile app repo are on their way,
but the API between the two code bases doesn't change a bit;
this won't break a thing if the
TB_MOBILE_CONTEXTvariable is set appropriately.