cp: show mode if target does not have S_IWUSR (PR #6696) #6700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the target exists, and does not have the user write bit (S_IWUSR) set, additional information should be added to the overwrite confirmation prompt. This should get the "i-2" test to pass. See uutils#6658.
Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
sylvestre
changed the title
|
could you please add a test to make sure we don't regress? |
|
I've added two tests. I will add some more in my next PR (which will address an edge case and fix another small bug in |
|
I missed this related PR: #6659. I've noticed some other issues in |
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
andrewliebenow
force-pushed
the
fix-issue-6658-rebased
branch
2 times, most recently
from
b601f9d
to
983dc61
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.