Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mv: gnu test case mv-n compatibility #6599

Merged
merged 9 commits into from
Sep 14, 2024
Merged

mv: gnu test case mv-n compatibility #6599

merged 9 commits into from
Sep 14, 2024

Conversation

matrixhead
Copy link
Contributor

@matrixhead matrixhead commented Jul 28, 2024 •
edited
Loading

fix for #6598

Behviours changed:

  • `-n' would now silently fail to copy a file when the destination already exists
  • added  --update=none-fail to cp and mv
  • arg parser would show a suggestion if parsing failed because of ambiguous value

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/mv/mv-n is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/mv/mv-n is no longer failing!

sylvestre
sylvestre reviewed Aug 2, 2024
View reviewed changes
src/uu/mv/src/mv.rs Outdated Show resolved Hide resolved
sylvestre
sylvestre reviewed Aug 2, 2024
View reviewed changes
tests/by-util/test_mv.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/mv/mv-n is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/mv/mv-n is no longer failing!

@matrixhead
Copy link
Contributor Author

matrixhead commented Aug 16, 2024 •
edited
Loading

changes in new commits

  • added --debug support for mv
  • cp would fail silently when -n is given, only prints a log when --debug is given

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/mv/mv-n is no longer failing!
Congrats! The gnu test tests/mv/update is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/mv/mv-n is no longer failing!
Congrats! The gnu test tests/mv/update is no longer failing!

@matrixhead matrixhead mentioned this pull request Aug 21, 2024
Open
@sylvestre sylvestre merged commit 8a9fb84 into uutils:main Sep 14, 2024
68 of 69 checks passed
@sylvestre
Copy link
Sponsor Contributor

well done and sorry for the latency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre Awaiting requested review from sylvestre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matrixhead @sylvestre