tr: A [:lower:]/[:upper:] in set2 must be matched in set1 #6445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a [:lower:] or [:upper:] in set2, then there must be a [:lower:] or [:upper:] at the same logical position in set1 So tr -t [:upper:] [:lower:] works tr -t 1[:upper:] [:lower:] doesnt
|
GNU testsuite comparison: |
sylvestre
reviewed
Jun 4, 2024
| @@ -91,18 +95,22 @@ pub enum Sequence { | |||
| } | |||
|
|
|||
| impl Sequence { | |||
| pub fn flatten(&self) -> Box<dyn Iterator<Item = u8>> { | |||
| pub fn flatten_non_lower_upper(&self) -> Box<dyn Iterator<Item = Self>> { | |||
There was a problem hiding this comment.
seem that you are duplicating a bunch of code with flatten?
maybe it could be deduplicated a bit, no?
There was a problem hiding this comment.
Logicwise, this code does not duplicate things. flatten_all calls flatten_non_upper_lower for everything that is not [:lower:]/[:upper:].
|
Thanks for your PR :) |
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a [:lower:] or [:upper:] in set2, then there must be a [:lower:] or [:upper:] at the same logical position in set1
So
To accomplish this change I have done the following things:
flatten error checks (take early exits from
solve_set_charactersinstead of nestingifs)simplify CharStar (
[c*]) handling code by simply replacing CharStar with a CharRepeat of appropriate lengthswitch flatten() from
Sequence -> u8toSequence -> CharThe main idea here is that to correctly implement the tr behaviour, one has to flatten everything but [:upper:]/[:lower:] into the underlying string of chars and then check if the character class in the one set is at the same position in the other set:
This apparent behavior is supported by these two GNU tr invocations: