cp: gnu test case preserve-mode fix #6432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
well done :) Some comments:
|
|
thank you, i will do that |
matrixhead
force-pushed
the
cp-preserve-mode
branch
from
b49fac3
to
c63e5e7
Compare
|
GNU testsuite comparison: |
matrixhead
force-pushed
the
cp-preserve-mode
branch
from
c63e5e7
to
a86b08a
Compare
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
matrixhead
force-pushed
the
cp-preserve-mode
branch
from
29dc78b
to
52481b7
Compare
|
GNU testsuite comparison: |
|
changes in force push
|
|
GNU testsuite comparison: |
sylvestre
reviewed
May 30, 2024
Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
|
GNU testsuite comparison: |
|
excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was initially intended to fix GNU test preserve-mode, but as it turns out, there was nothing wrong with how
uu-cppreserved mode. The test was failing because overriding wasn't working properly. The test involved copying a FIFO with options-a --preserve=mode. The-awas supposed to disable copying contents, but it was getting overridden by--preservewrongly. So, this PR now tries to fix the overriding of attributes.changes in behavior
-awhich expands to-dR --preserve=allis given and a --preserve is given after that, cp would only override the --preserve part.--preserveand--no-preservetogether in a single command, for examplecp --preserve=mode,ownership --no-preserve=ownership --preserve=link f f2would preserve mode and link but not the ownership