Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: accept repeated arguments #6355

Merged
merged 2 commits into from
May 5, 2024

Conversation

BenWiederhake
Copy link
Collaborator

Turns out, just a simple args_override_self(true) is precisely the correct behavior.

This is also correct with regard to -p, -w, -g; I checked (and found #6352, #6353, #6354 in the process of doing so).

This is work towards #5998.

Note that even though I added some basic tests, a huge chunk of the functionality is still untested, especially -c, -x/-X, -t, -m, -q, -T, and of course -g, which is broken (known issue).

@BenWiederhake
Copy link
Collaborator Author

Changes since last push: Forgot to commit the test data, whoops :D

@BenWiederhake
Copy link
Collaborator Author

Remaining failures are due to #6275 and #6333.

tests/by-util/test_fmt.rs Outdated Show resolved Hide resolved
tests/by-util/test_fmt.rs Outdated Show resolved Hide resolved
@BenWiederhake
Copy link
Collaborator Author

Changes since last push:

  • rebased
  • extracted common arg to common arg() (thanks @cakebaker!)
  • use stdout_is_fixture as appropriate (thanks @cakebaker!)

@BenWiederhake
Copy link
Collaborator Author

Changes since last push:

  • Now that at_and_ucmd is no longer needed, don't use it. (duh)

@cakebaker cakebaker merged commit f9b4fad into uutils:main May 5, 2024
67 of 68 checks passed
@cakebaker
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants