Fix ls: panicking on dangling symlink with --color=auto -l

[AnirbanHalder654322]

fixes #6227

The get_metadata() function seemed to try to deference to the non existent file. We change it to directly get the metadata of the symlink itself incase the deference fails.

[BenWiederhake]

Thanks for tackling this!

• I'm not yet entirely convinced that the second invocation is actually needed
• If it is needed, what do we do if it fails?
• And of course, please write tests so that we can't regress if we change this in the future :D
• EDIT: Oh, and please fix the typo in the commit message :)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

[AnirbanHalder654322]

Changes since last push :

• Changed the logic to use

        let md_res = get_metadata_with_deref_opt(target.p_buf.as_path(), path.must_dereference);
        let md = md_res.or(target.p_buf.symlink_metadata());

        apply_style_based_on_metadata(path, md.as_ref(),ok(), ls_colors, style_manager, &name)

• Added test

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

[BenWiederhake]

Fixes the problem, and adds a test. Yay!

It looks to me like the test can be simplified by a lot, what did I miss?

[AnirbanHalder654322]

Changes since last push:

• Using at.symlink_file for symlink creation
• Switched to regex matching for extracting colors from stdout
• Squashed the commit into an older comment formatting commit to clean up history .

[BenWiederhake]

Just one last nitpick, then it can be merged :)

[AnirbanHalder654322]

I was wondering if i should clean up the commit history a bit more ? Maybe only leave two commits one for the main change and another for the test ?

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

[BenWiederhake]

LGTM 👍

[BenWiederhake]

Still looks good ^^