Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the debug results in cp --debug #6220

Merged
merged 11 commits into from
Apr 22, 2024

Conversation

AnirbanHalder654322
Copy link
Contributor

@AnirbanHalder654322 AnirbanHalder654322 commented Apr 12, 2024

Fixes #5715
If this passes , i can close my other pr #6130 . This pr contains the changes of that one too in a more structured way.

Passes compatibility tests

  • tests/cp/sparse-perf.sh
  • tests/cp/sparse-2.sh
  • tests/cp/sparse-extents.sh
  • tests/cp/sparse-extents-2.sh

@AnirbanHalder654322 AnirbanHalder654322 changed the title Fix the debug results in Fix the debug results in ~cp --debug~ Apr 12, 2024
@AnirbanHalder654322 AnirbanHalder654322 marked this pull request as draft April 12, 2024 18:24
@AnirbanHalder654322 AnirbanHalder654322 changed the title Fix the debug results in ~cp --debug~ Fix the debug results in cp --debug Apr 12, 2024
@AnirbanHalder654322 AnirbanHalder654322 marked this pull request as ready for review April 12, 2024 18:31
Copy link

GNU testsuite comparison:

GNU test failed: tests/cp/same-file. tests/cp/same-file is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
GNU test failed: tests/cp/cross-dev-symlink. tests/cp/cross-dev-symlink is passing on 'main'. Maybe you have to rebase?

@sylvestre
Copy link
Sponsor Contributor

GNU testsuite comparison:

GNU test failed: tests/cp/same-file. tests/cp/same-file is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
GNU test failed: tests/cp/cross-dev-symlink. tests/cp/cross-dev-symlink is passing on 'main'. Maybe you have to rebase?

interesting, they are marked as passing in the log but don't show here?!

2024-04-14T08:02:24.9545868Z PASS: tests/cp/sparse-extents.sh
2024-04-14T08:02:25.3753424Z PASS: tests/cp/sparse-perf.sh
2024-04-14T08:02:25.6187557Z PASS: tests/cp/sparse-2.sh
[...]
2024-04-14T08:02:59.5016730Z PASS: tests/cp/sparse-extents-2.sh

Copy link

GNU testsuite comparison:

GNU test failed: tests/cp/same-file. tests/cp/same-file is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/cross-dev-symlink. tests/cp/cross-dev-symlink is passing on 'main'. Maybe you have to rebase?

Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@sylvestre
Copy link
Sponsor Contributor

a clippy warning:


error: casting integer literal to `u8` is unnecessary
    --> tests/by-util/test_cp.rs:3961:25
     |
3961 |     let filler_bytes = [0 as u8; 10000];
     |                         ^^^^^^^ help: try: `0_u8`
     |

Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/factor/factor is no longer failing!

Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@AnirbanHalder654322
Copy link
Contributor Author

a clippy warning:


error: casting integer literal to `u8` is unnecessary
    --> tests/by-util/test_cp.rs:3961:25
     |
3961 |     let filler_bytes = [0 as u8; 10000];
     |                         ^^^^^^^ help: try: `0_u8`
     |

@sylvestre fixed it now.

@sylvestre
Copy link
Sponsor Contributor

I still don't get why we didn't get a comment but well done :)


Warning: Changes from 'main': PASS +4 / FAIL +1 / ERROR +0 / SKIP -5 

2024-04-21T14:14:08.9573439Z PASS: tests/cp/sparse-extents.sh
2024-04-21T14:14:09.3762254Z PASS: tests/cp/sparse-perf.sh
2024-04-21T14:14:09.5998242Z PASS: tests/cp/sparse-2.sh
...

any idea @tertsdiepraam ?
https://github.com/uutils/coreutils/actions/runs/8773385445/job/24073401789 doesn't say much

@sylvestre sylvestre merged commit 421b820 into uutils:main Apr 22, 2024
68 checks passed
@sylvestre
Copy link
Sponsor Contributor

we see it here:
https://github.com/uutils/coreutils-tracking/


  "Mon, 22 Apr 2024 14:02:19 +0000": {
    "sha": "a1cdab3d6074755bbe1f3c2fb5eb9f2b4075d2ca",
    "total": "612",
    "pass": "440",
    "skip": "49",
    "fail": "123",
    "xpass": "0",
    "error": "0"
  },
  "Mon, 22 Apr 2024 15:59:55 +0000": {
    "sha": "421b820ec2105bf8b2192d39541beeec52e60e51",
    "total": "612",
    "pass": "445",
    "skip": "44",
    "fail": "123",
    "xpass": "0",
    "error": "0"
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cp --debug should show when sparse detection: SEEK_HOLE
2 participants