Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill: print signals vertically when using --list flag #6201

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

m-haisham
Copy link
Contributor

Environment: Ubuntu 20.04, uutils main branch (git commit 415de28), GNU coreutils version 9.5.3-8f39 (from git commit coreutils/coreutils@8f3989d).

See #6197 for more details.

Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah! Short and sweet :D

Copy link

github-actions bot commented Apr 7, 2024

GNU testsuite comparison:

GNU test failed: tests/misc/kill. tests/misc/kill is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/kill is no longer ERROR!
GNU test failed: tests/cp/cross-dev-symlink. tests/cp/cross-dev-symlink is passing on 'main'. Maybe you have to rebase?

@m-haisham m-haisham force-pushed the main branch 2 times, most recently from 697d85d to 0bc6d16 Compare April 7, 2024 17:57
@m-haisham
Copy link
Contributor Author

Accidentally pushed table formatting code to this branch, I've rolled it back.

Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@m-haisham
Copy link
Contributor Author

Failed check does not seem to be related to this tool. @BenWiederhake

@BenWiederhake BenWiederhake merged commit 843407f into uutils:main Apr 7, 2024
63 of 64 checks passed
@BenWiederhake
Copy link
Collaborator

Thank you!

@sylvestre
Copy link
Sponsor Contributor

it would have been nice to have a test to make sure we don't regress in the future

@BenWiederhake
Copy link
Collaborator

You're right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants