tr: lazily generate the character mapping as necessary #6092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
don't worry, you aren't rude at all :) |
Thank you! I'm so glad and honored to contribute code to uutils, really like the project! |
cakebaker
approved these changes
Mar 18, 2024
|
Thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a TODO that I think I can help with, I tried to complete this TODO in a very simple way, but I'm not sure if I can achieve the right result.
In my CI, GNU Tests instead has an extra failure, which as I understand should not be a problem, this just initializes the value when needed, could this value be modified? But I didn't find any other modifications.