Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dd fix gnu test not-rewound.sh #6088

Merged
merged 1 commit into from
Mar 17, 2024
Merged

dd fix gnu test not-rewound.sh #6088

merged 1 commit into from
Mar 17, 2024

Conversation

cre4ture
Copy link
Contributor

No description provided.

@cre4ture cre4ture force-pushed the fix/gnu_test_dd_not_rewound_sh branch from 6c0ff65 to 3137bd3 Compare March 16, 2024 16:30
@cre4ture cre4ture mentioned this pull request Mar 16, 2024
Closed
@cakebaker cakebaker linked an issue Mar 16, 2024 that may be closed by this pull request
dd fails on gnu test test/dd/not-rewound.sh - fix available #6089
Closed
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/not-rewound is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/not-rewound is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@cre4ture cre4ture force-pushed the fix/gnu_test_dd_not_rewound_sh branch from 9d2578d to 3c6079f Compare March 16, 2024 18:24
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/not-rewound is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout is no longer failing!

@sylvestre
Copy link
Sponsor Contributor

would it be possible to replicate this test on our side? thanks

@cre4ture cre4ture changed the title Fix/gnu test dd not rewound sh dd fix gnu test not-rewound.sh Mar 17, 2024
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/not-rewound is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout is no longer failing!

@cre4ture cre4ture force-pushed the fix/gnu_test_dd_not_rewound_sh branch from 563226a to 3de43ad Compare March 17, 2024 16:59
@cre4ture
Copy link
Contributor Author

@sylvestre test added. ready for review. :-)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/not-rewound is no longer failing!
Congrats! The gnu test tests/timeout/timeout is no longer failing!

sylvestre
sylvestre reviewed Mar 17, 2024
View reviewed changes
src/uucore/src/lib/mods/io.rs
@@ -0,0 +1,83 @@
// This file is part of the uutils coreutils package.
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please document it?
As it will be part of the API like:
https://docs.rs/uucore/0.0.24/uucore/error/index.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats cool.
I added some documentation.
Thanks.

@cre4ture
re-use existing fd for stdout even if its a seek-able file
4057717 
this is important as the fd holds the file offset we need to use
@cre4ture cre4ture force-pushed the fix/gnu_test_dd_not_rewound_sh branch from 3de43ad to 4057717 Compare March 17, 2024 19:46
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/not-rewound is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout is no longer failing!

@sylvestre sylvestre merged commit 6966150 into uutils:main Mar 17, 2024
62 checks passed
@cre4ture cre4ture deleted the fix/gnu_test_dd_not_rewound_sh branch March 18, 2024 20:58
@chenrui333 chenrui333 mentioned this pull request Mar 24, 2024
Merged
@moonfruit moonfruit mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dd fails on gnu test test/dd/not-rewound.sh - fix available
2 participants
@cre4ture @sylvestre