dd: handle SIGUSR1 directly. not just every 1sec #6025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cre4ture
changed the title
cre4ture
force-pushed
the
feature/dd_direct_progress
branch
3 times, most recently
from
6eca368
to
cf5fc49
Compare
cre4ture
force-pushed
the
feature/dd_direct_progress
branch
from
cf5fc49
to
c2613ad
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Mar 23, 2024
| } | ||
| }); | ||
|
|
||
| Self { interval, trigger } | ||
| } | ||
|
|
||
| pub fn is_triggered(&self) -> bool { | ||
| self.trigger.swap(false, Relaxed) | ||
| pub fn manual_trigger_fn(&self) -> Box<dyn Send + Sync + Fn()> { |
There was a problem hiding this comment.
it would be nice to add some comments explaining what it is doing
sylvestre
reviewed
Mar 23, 2024
| @@ -913,6 +950,27 @@ impl<'a> BlockWriter<'a> { | |||
| } | |||
| } | |||
|
|
|||
| fn flush_caches_full_length(i: &Input, o: &Output) -> std::io::Result<()> { | |||
sylvestre
force-pushed
the
feature/dd_direct_progress
branch
from
c2613ad
to
a35dafc
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses issue #5902.
The relevant gnu test
tests/dd/stats.shis now green.Changes:
fullblockcmd line arg. It retries partial writes when this is set.