Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uniq: Fix flaky test gnu_tests #6017

Merged

Conversation

BenWiederhake
Copy link
Collaborator

The testcase tries to write to the stdin pipe while the process under test is simultaneously exiting with an error code. Naturally, this is a race, and we should ignore any stdin write errors. However, adding this feature to the list makes it even more unreadable, and adds no real value, so let's skip the input data entirely.

This flake causes real problems.

The testcase tries to write to the stdin pipe while the process under
test is simultaneously exiting with an error code. Naturally, this is a
race, and we should ignore any stdin write errors. However, adding this
feature to the list makes it even more unreadable, and adds no real
value, so let's skip the input data entirely.
@BenWiederhake BenWiederhake force-pushed the dev-uniq-flake-stdin-write-gnutest branch from d7ac0ef to e91d0bd Compare February 25, 2024 16:59
@BenWiederhake
Copy link
Collaborator Author

Changes since last push: Changed "F" to "f" in commit subject. (That seems to be the style of this project.)

Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@BenWiederhake
Copy link
Collaborator Author

These CI flakes are maddening.

--- TRY 3 STDERR:        coreutils::tests common::util::tests::test_uchild_when_run_no_wait_with_a_non_blocking_util ---
thread 'main' panicked at tests/common/util.rs:3117:13:
Assertion failed: child process is still alive.

Looks like Android CI just seriously took over 5 seconds to execute echo "hello world", three times in a row.

There's not much I can do, and more importantly: That doesn't mean there's anything wrong with this PR. I'll just ignore it.

@cakebaker cakebaker merged commit d8e6f36 into uutils:main Feb 26, 2024
61 of 62 checks passed
@cakebaker
Copy link
Contributor

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants