Un-Ignore two tests that fail for nonsense reasons #5997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment was introduced in commit 8320b1e, the test was introduced in commit c1f518e claiming to be about "failing GNU head tests". However, a simple check reveals no such difference: ```console $ echo -n a | hd 00000000 61 |a| 00000001 $ echo -n a | head | hd # GNU head 00000000 61 |a| 00000001 $ echo -n a | cargo run -- head | hd 00000000 61 |a| 00000001 $ echo -n a | busybox head | hd 00000000 61 |a| 00000001 $ ``` Looking at the GNU tests directly, it seems that there is a similar, but different test.
tertsdiepraam
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR un-ignores two tests:
test_head::test_spams_newlineset a wrong expectation. A simple comparison with GNU head and busybox head reveals that the test was flawed, and plugging in the correct output passes the test.test_touch::test_touch_invalid_date_formathad a simple typo: Apparently someone accidentally copy-pasted typographic quotation marks instead of the usual "ASCII" quotation marks. Changing this passes the test.