Handle better some errors #5791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fails on Windows: |
sylvestre
force-pushed
the
handle-error
branch
from
4e2b6ac
to
8eb58b3
Compare
Comment on lines
+83
to
+87
| Err(e) => { | ||
| set_exit_code(1); | ||
| show_error!("error reading input: {}", e); | ||
| return Ok(()); | ||
| } |
There was a problem hiding this comment.
This feels very similar to what UIoError does, but this is also quite clear, so it's fine.
There was a problem hiding this comment.
not sure how to do that with the Ok? do you we have other examples ?
tests/by-util/test_factor.rs
Outdated
|
|
||
| #[test] | ||
| fn fails_on_directory() { | ||
| new_ucmd!().arg("<").arg(".").fails(); |
There was a problem hiding this comment.
This fails as it should, but not for the reason you're expecting. The < will not pipe here. It will be an argument to factor, so factor '<' '.'.
There was a problem hiding this comment.
ah ah, fun :)
sylvestre
force-pushed
the
handle-error
branch
from
8eb58b3
to
8e53ab0
Compare
sylvestre
force-pushed
the
handle-error
branch
from
8e53ab0
to
3d356d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for these two fixes, it was breaking some Rust errors
tested in tests/misc/read-errors.sh