Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cksum: Add --length argument for the blake2b algorithm #5749

Merged
merged 9 commits into from
Dec 30, 2023
Merged

cksum: Add --length argument for the blake2b algorithm #5749

merged 9 commits into from
Dec 30, 2023

Conversation

DitherWither
Copy link
Contributor

Should close #5707

This adds the --length (short form -l) option, along with unit tests for it

It allows you to specify the output digest size for the blake2b algorithm

cakebaker
cakebaker reviewed Dec 30, 2023
View reviewed changes
Copy link
Contributor

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

There are two special cases of length values that are currently not covered and lead to a panic: 0 and lengths > 512 that are divisible by 8.

@DitherWither
Copy link
Contributor Author

@cakebaker

Ok, I handled those values, and also added tests for the same

@cakebaker cakebaker merged commit 8fe1b26 into uutils:main Dec 30, 2023
54 of 56 checks passed
@cakebaker
Copy link
Contributor

Great job, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement cksum -l
2 participants
@DitherWither @cakebaker