install: remove / from end of path if it exists so as not to mess with .exists() #5730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakebaker
changed the title
|
The change unfortunately breaks the |
I'll look into it. Thanks for the support. |
|
GNU testsuite comparison: |
|
@cakebaker should be alright now. Let me know what else I have to do before the merge. |
|
could you please add a test ? thanks |
Done. |
|
GNU testsuite comparison: |
|
Thanks for your PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5720 fix.
I figured paths ending in "/" make .exists() not work properly so I added a check as to remove the / if there is one.