cp/mv/ln: add support for the "will not overwrite just-created" #5699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should help with tests/mv/childproof.sh
Should help with tests/mv/childproof.sh
Should help with tests/mv/childproof.sh
|
GNU testsuite comparison: |
sylvestre
commented
Dec 23, 2023
| @@ -1171,6 +1171,9 @@ pub fn copy(sources: &[PathBuf], target: &Path, options: &Options) -> CopyResult | |||
| // | |||
| // key is the source file's information and the value is the destination filepath. | |||
| let mut copied_files: HashMap<FileInformation, PathBuf> = HashMap::with_capacity(sources.len()); | |||
| // remember the copied destinations for further usage. | |||
| // we can't use copied_files as it is because the key is the source file's information. | |||
| let mut copied_destinations: HashSet<PathBuf> = HashSet::with_capacity(sources.len()); | |||
There was a problem hiding this comment.
i will open a good first bug after to avoid "duplication" here
|
i have another PR pending based on this one to fix |
|
Fails on Windows :| |
|
|
cakebaker
reviewed
Dec 25, 2023
|
GNU testsuite comparison: |
cakebaker
reviewed
Dec 25, 2023
cakebaker
reviewed
Dec 25, 2023
cakebaker
reviewed
Dec 25, 2023
cakebaker
reviewed
Dec 25, 2023
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
sylvestre
force-pushed
the
mv-cp-seen
branch
from
2154b5a
to
60d71e3
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix: tests/mv/childproof.sh