Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ls: remove condition with unreachable "else" block #5687

Merged
merged 1 commit into from
Dec 21, 2023
Merged

ls: remove condition with unreachable "else" block #5687

merged 1 commit into from
Dec 21, 2023

Conversation

cakebaker
Copy link
Contributor

This PR removes a cfg!(unix) condition with an unreachable else block. It is unreachable because the enclosing code is already in a #[cfg(unix)] block.

@sylvestre
Copy link
Sponsor Contributor

i wonder if clippy could not catch this :)
cc @samueltardieu

@sylvestre sylvestre merged commit 95852db into uutils:main Dec 21, 2023
54 of 56 checks passed
@cakebaker cakebaker deleted the ls_remove_condition branch December 21, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @sylvestre