Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ls: rename display_file_name to display_item_name #5675

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

cakebaker
Copy link
Contributor

This PR renames the function display_file_name to display_item_name because the function is not limited to file names.

@sylvestre
Copy link
Sponsor Contributor

The doc gen is failing with:


error: unresolved link to `display_file_name`
    --> src/uu/ls/src/ls.rs:2547:22
     |
2547 | /// * `file_name` ([`display_file_name`])
     |                      ^^^^^^^^^^^^^^^^^ no item named `display_file_name` in scope
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

@sylvestre sylvestre merged commit 5cc5aa7 into uutils:main Dec 19, 2023
52 of 56 checks passed
@cakebaker cakebaker deleted the ls_rename_display_file_name branch December 19, 2023 10:11
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate
GNU test failed: tests/tail/truncate. tests/tail/truncate is passing on 'main'. Maybe you have to rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants