fuzz printf #5556
Merged
fuzz printf #5556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakebaker
reviewed
Nov 20, 2023
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
cakebaker
reviewed
Nov 20, 2023
|
|
||
| fn generate_printf() -> String { | ||
| let mut rng = rand::thread_rng(); | ||
| let format_specifiers = ["%s", "%d", "%f", "%x", "%o", "%c", "%b", "%q"]; |
There was a problem hiding this comment.
I'm not sure about the format specifiers. For example, https://www.gnu.org/savannah-checkouts/gnu/libc/manual/html_node/Table-of-Output-Conversions.html lists many more.
There was a problem hiding this comment.
yeah, it is just to start :)
|
GNU testsuite comparison: |
cakebaker
reviewed
Nov 20, 2023
There was a problem hiding this comment.
It looks fine to me for a first version, though I'm not sure whether we should merge it yet as @tertsdiepraam works on a rewrite of printf.
|
It doesn't matter because it is testing the binaries, it doesn't rely on internal :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.