stdbuf: remove crash macro

[cswn]

This is related to issue: #5487
Removes the crash! macro from stdbuf.

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/tail/inotify-dir-recreate. tests/tail/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?

[cakebaker]

Did you see that test_stdbuf_invalid_mode_fails now fails?

[cswn]

No, I didn't, will take a look now

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/tail/symlink is no longer failing!
GNU test failed: tests/tail/inotify-dir-recreate. tests/tail/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

[tertsdiepraam]

Nice! Just one suggestion

[tertsdiepraam]

I think this lines should not be necessary. The exit code should be added to the error here:

coreutils/src/uu/stdbuf/src/stdbuf.rs

Line 151 in 26df944

let options = ProgramOptions::try_from(&matches).map_err(|e| UUsageError::new(125, e.0))?;

It'd be great if you could also verify that this is actually the case by writing a test for it.

[cswn]

Ah, you're right, I've taken that line out. However, the test already asserts that the error code is 125: https://github.com/cswn/coreutils/blob/26df9445fb70152abfd523c0bdb75def6c7d5475/tests/by-util/test_stdbuf.rs#L67C9-L67C9

[tertsdiepraam]

Cool!

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/tail/truncate. tests/tail/truncate is passing on 'main'. Maybe you have to rebase?

[cakebaker]

Thanks!