Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ls: fix panic when file removed too quickly #5372

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Conversation

sanpii
Copy link
Contributor

@sanpii sanpii commented Oct 7, 2023

Fixes #5371

@tertsdiepraam
Copy link
Member

tertsdiepraam commented Oct 7, 2023

This seems like a good solution! If the file disappeared there's not much we can do anymore except just print it as we first got it. Could you add a comment in there explaining why this is necessary?

Also, I guess a test for this would be very unreliable right? Or do you have a reliable way to test this? If you do, it'd be great if you could add that to the test suite.

@sanpii
Copy link
Contributor Author

sanpii commented Oct 7, 2023

Could you add a comment in there explaining why this is necessary?

Comment added.

Also, I guess a test for this would be very unreliable right? Or do you have a reliable way to test this? If you do, it'd be great if you could add that to the test suite.

Testing this seems impossible with the actual test tool, we need fine control on process to suspend it quickly.

@sylvestre sylvestre merged commit c53ca6d into uutils:main Oct 8, 2023
43 of 45 checks passed
@sylvestre
Copy link
Sponsor Contributor

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ls panicked
3 participants