Implement SI prefixes R and Q #5357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
221
to
222
| /// /// GNU lib/coreutils include similar functionality | ||
| /// and GNU test suite checks this behavior for some utils |
There was a problem hiding this comment.
Which ones do this? This feels like something unrelated to adding R and Q and I'd like to consider it separately, because it can also happen for Y for example.
There was a problem hiding this comment.
specifically split does this and their lib includes function in support of that (i.e. return long int max on overflow if I recall correctly). This comment is actually from code that was already there for u64 variant - just duplicated it for u128 version of that
zhitkoff
force-pushed
the
issue5334-uucore-parse-r-q
branch
4 times, most recently
from
a562933
to
7ee3b58
Compare
|
rebased a few more times |
zhitkoff
force-pushed
the
issue5334-uucore-parse-r-q
branch
from
7ee3b58
to
abc9536
Compare
|
@sylvestre could you please help with merging this one since it looks like @tertsdiepraam is traveling? |
|
yeah, great work. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing support for Ronna (R) and Quetta (Q) SI prefixes
Fixes #5334