Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cp: fix cp -a --no-preserve=mode doesn't keep fully the mode #5353

Merged
merged 20 commits into from
Oct 25, 2023
Merged

cp: fix cp -a --no-preserve=mode doesn't keep fully the mode #5353

merged 20 commits into from
Oct 25, 2023

Conversation

tommady
Copy link
Contributor

@tommady tommady commented Oct 4, 2023

fix #5327

@tommady tommady marked this pull request as draft October 4, 2023 06:55
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

GNU testsuite comparison:

Congrats! The gnu test tests/cp/link-preserve is no longer failing!

@tommady tommady marked this pull request as ready for review October 4, 2023 10:12
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

GNU testsuite comparison:

Congrats! The gnu test tests/cp/link-preserve is no longer failing!

sylvestre
sylvestre reviewed Oct 10, 2023
View reviewed changes
src/uu/cp/src/cp.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/cp/link-preserve is no longer failing!

sylvestre
sylvestre reviewed Oct 11, 2023
View reviewed changes
src/uu/cp/src/cp.rs Outdated Show resolved Hide resolved
sylvestre
sylvestre reviewed Oct 11, 2023
View reviewed changes
src/uu/cp/src/cp.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/cp/link-preserve is no longer failing!
Congrats! The gnu test tests/ls/w-option is no longer failing!
GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

tommady and others added 3 commits October 12, 2023 10:42
@tommady @sylvestre
Update src/uu/cp/src/cp.rs
7ea19c7 
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
@tommady @sylvestre
Update src/uu/cp/src/cp.rs
9be5583 
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
@tommady
fix linter errors
c9fa070
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/cp/link-preserve is no longer failing!

cakebaker
cakebaker reviewed Oct 25, 2023
View reviewed changes
tests/by-util/test_cp.rs Outdated Show resolved Hide resolved
cakebaker
cakebaker reviewed Oct 25, 2023
View reviewed changes
src/uu/cp/src/cp.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/cp/link-preserve is no longer failing!

@cakebaker cakebaker merged commit 6085cf1 into uutils:main Oct 25, 2023
43 of 45 checks passed
@cakebaker
Copy link
Contributor

Thanks for your PR :)

@tommady tommady deleted the fix-5327 branch October 26, 2023 01:38
@chenrui333 chenrui333 mentioned this pull request Nov 14, 2023
Merged
@moonfruit moonfruit mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre left review comments

@cakebaker cakebaker cakebaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cp -a --no-preserve=mode doesn't keep fully the mode
3 participants
@tommady @cakebaker @sylvestre