hashsum: use file_stem() instead of file_name() #5020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This program matches the binary name to determine which algorithm to use. On Windows, `file_name()` was matching against a string with `.exe`, causing binaries like `sha256sum.exe` to not properly detect the algorithm. By using `file_stem()`, we exclude the `.exe` from matching, achieving similar and correct behavior on Windows.
sylvestre
force-pushed
the
hashsum-file-stem
branch
from
5fd4edf
to
a7f95d5
Compare
|
Thanks for your PR :) |
|
i was wondering if we could not add a test for this? |
|
@sylvestre how would you write a test for this? I tried to add one to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This program matches the binary name to determine which algorithm to use. On Windows,
file_name()was matching against a string with.exe, causing binaries likesha256sum.exeto not properly detect the algorithm.By using
file_stem(), we exclude the.exefrom matching, achieving similar and correct behavior on Windows.