Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

df: disable failing tests on Windows #5017

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

cakebaker
Copy link
Contributor

@cakebaker cakebaker commented Jun 28, 2023

This PR disables the four tests mentioned in #5015 on Windows.

@sylvestre
Copy link
Sponsor Contributor

I would like to know a bit more why we regressed :/

@cakebaker
Copy link
Contributor Author

Yes, that would be nice, though I have no more ideas how to figure it out. In my experiments (running cargo update; testing v0.0.19; using windows 2019 in the workflow file) the four df tests still failed on Windows.

@sylvestre
Copy link
Sponsor Contributor

@cakebaker #5026 some improvements here
once it is merged, we can adjust this PR

@sylvestre sylvestre merged commit 6e3ab23 into uutils:main Jul 3, 2023
45 checks passed
@cakebaker cakebaker deleted the df_disable_some_tests_on_windows branch July 3, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants