Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

du: directories have apparent size of 0 #4991

Merged
merged 1 commit into from
Jun 26, 2023
Merged

du: directories have apparent size of 0 #4991

merged 1 commit into from
Jun 26, 2023

Conversation

shinhs0506
Copy link
Contributor

No description provided.

@shinhs0506 shinhs0506 force-pushed the du_apparent branch 2 times, most recently from de8caaa to e47fc34 Compare June 20, 2023 19:54
@github-actions
Copy link

github-actions bot commented Jun 20, 2023 •
edited by sylvestre
Loading

GNU testsuite comparison:

Congrats! The gnu test tests/du/apparent is no longer failing!

@github-actions
Copy link

github-actions bot commented Jun 20, 2023 •
edited by sylvestre
Loading

GNU testsuite comparison:

Congrats! The gnu test tests/du/apparent is no longer failing!

@shinhs0506 shinhs0506 marked this pull request as ready for review June 20, 2023 21:34
cakebaker
cakebaker reviewed Jun 21, 2023
View reviewed changes
tests/by-util/test_du.rs Outdated Show resolved Hide resolved
cakebaker
cakebaker reviewed Jun 21, 2023
View reviewed changes
tests/by-util/test_du.rs Outdated Show resolved Hide resolved
cakebaker
cakebaker reviewed Jun 21, 2023
View reviewed changes
tests/by-util/test_du.rs Outdated Show resolved Hide resolved
cakebaker
cakebaker reviewed Jun 21, 2023
View reviewed changes
tests/by-util/test_du.rs Outdated Show resolved Hide resolved
@cakebaker
Copy link
Contributor

cakebaker commented Jun 21, 2023 •
edited
Loading

When I run the updated tests, without applying the changes to du.rs, all tests pass. Is that intentional?

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/du/apparent is no longer failing!

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/du/apparent is no longer failing!
Skipping an intermittent issue tests/tail-2/inotify-dir-recreate

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/du/apparent is no longer failing!

@shinhs0506
Copy link
Contributor Author

@cakebaker everything resolved, thanks :)

@cakebaker cakebaker merged commit 9149409 into uutils:main Jun 26, 2023
44 of 45 checks passed
@cakebaker
Copy link
Contributor

Thanks! Good idea of introducing stdout_contains_line, it's a much cleaner solution than what I suggested.

@cakebaker cakebaker mentioned this pull request Aug 4, 2023
Open
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shinhs0506 @cakebaker