Make tests/help/help-version-getopt.sh pass #4987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test: tests/help/help-version-getopt.sh
* "hostid BEFORE --help" doesn't fail for GNU. we fail. we are probably doing better * "hostid BEFORE --help AFTER " same for this
cakebaker
reviewed
Jun 20, 2023
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
cakebaker
reviewed
Jun 20, 2023
Comment on lines
+236
to
+239
| # disable two kind of tests: | ||
| # "hostid BEFORE --help" doesn't fail for GNU. we fail. we are probably doing better | ||
| # "hostid BEFORE --help AFTER " same for this | ||
| sed -i -e "s/env \$prog \$BEFORE \$opt > out2/env \$prog \$BEFORE \$opt > out2 #/" -e "s/env \$prog \$BEFORE \$opt AFTER > out3/env \$prog \$BEFORE \$opt AFTER > out3 #/" -e "s/compare exp out2/compare exp out2 #/" -e "s/compare exp out3/compare exp out3 #/" tests/misc/help-version-getopt.sh |
There was a problem hiding this comment.
Wouldn't it be simpler to just remove hostid from the file?
There was a problem hiding this comment.
hostid is just an example, others might fail to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.