mv: fix into-self-2.sh test #4966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could handle it for Windows in the same way it is done for the |
sylvestre
reviewed
Jun 10, 2023
Skryptonyte
force-pushed
the
mv_selfinto2fix
branch
from
61e83f2
to
25e14bb
Compare
Skryptonyte
force-pushed
the
mv_selfinto2fix
branch
from
25e14bb
to
6bc15aa
Compare
|
GNU testsuite comparison: |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In normal GNU mv behaviour, moving a symlink to a file with target as file should fail which this one does currently, but vice versa must actually succeed. I have slightly changed the approach of mv so that when checking for same link, only the source path's symbolic link is resolved fully while target is taken as is which seems to fix some edge cases.
I am a bit unsure of how to handle this on Windows however.