Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mkdir: explicit umask and sequential tests #4896

Merged
merged 3 commits into from
May 25, 2023

Conversation

shinhs0506
Copy link
Contributor

@shinhs0506 shinhs0506 commented May 23, 2023

  1. explicitly set umask when testing file mode (mkdir: set correct permissions on dirs created by -p #4876 (comment))
  2. run tests sequentially since tests that do set umask cause other tests to fail

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/timeout. tests/misc/timeout is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@cakebaker
Copy link
Contributor

Why don't you set umask in test_symbolic_mode and test_multi_symbolic?

@cakebaker
Copy link
Contributor

Never mind, you set the permissions in an "absolute" way.

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@cakebaker cakebaker merged commit 79df393 into uutils:main May 25, 2023
@cakebaker
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants