cp: fix cp -f f loop when loop is a symlink loop #4820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
cakebaker
reviewed
May 3, 2023
src/uucore/src/lib/features/fs.rs
Outdated
| /// | ||
| /// * An `io::Result<()>` that is `Ok(())` if no symlink loop is detected, or an error with `io::ErrorKind::InvalidInput` | ||
| /// if a loop is detected. | ||
| pub fn detect_symlink_loop(path: &Path) -> io::Result<()> { |
There was a problem hiding this comment.
This function feels a bit weird because in the success case (a symlink loop is detected) it returns an error. As you use this function anyway as if it returns a bool, I would just return a bool and rename it to something like is_symlink_loop.
Fix: tests/cp/thru-dangling.sh
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: tests/cp/thru-dangling.sh