shred: refactor to clean up code and reduce syscalls
#4493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
tertsdiepraam
force-pushed
the
shred-expand-buffer-size
branch
from
65d620b
to
644fc14
Compare
|
GNU testsuite comparison: |
This buffer size matches GNU
Also contains some cleanup
tertsdiepraam
force-pushed
the
shred-expand-buffer-size
branch
4 times, most recently
from
d6393c3
to
bd0037b
Compare
sylvestre
reviewed
Mar 13, 2023
sylvestre
reviewed
Mar 13, 2023
sylvestre
reviewed
Mar 13, 2023
sylvestre
reviewed
Mar 13, 2023
tertsdiepraam
force-pushed
the
shred-expand-buffer-size
branch
from
bd0037b
to
ae53b70
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Mar 24, 2023
sylvestre
reviewed
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4490
Should have some performance improvements too, but the numbers are way to varied to give an exact number. Turns out that the
shredcode did a lot of things quite weirdly, so I just kept finding things to refactor.I'll mark this ready after I've looked at the filename generator and cleaned that up too.